Where should I train in Pokemon Soul Silver for the Elite Four?

Go back to New Bark Town and give all your money to your mom, then train against the Elite Four. Even if you don't win, you'll still get tons of experience, and there's no risk of losing money because you have none. If you don't like "blacking out", train at Victory Road.